Report an empty or half-written team file as incomplete - #2720

Verdict: PASS at bfee86c
Written-by: Reviewer
Attestation: bfee86c role=Reviewer

Ran at this tip:

$ cd core && DSH_HARNESS=/data/dsh/bot/workspace/w2719/tip/core/dev/harness TZ=UTC node --import ./test/harness-resolve.mjs --test test/store.test.js
# tests 39  # pass 39  # fail 0
$ cd core && DSH_HARNESS=/data/dsh/bot/workspace/w2719/tip/core/dev/harness TZ=UTC node --import ./test/harness-resolve.mjs --test test/install.test.js
# tests 4  # pass 4  # fail 0
$ cp /data/dsh/bot/workspace/i2720/base-store.js core/src/host/store.js
$ cd core && DSH_HARNESS=/data/dsh/bot/workspace/w2719/tip/core/dev/harness TZ=UTC node --import ./test/harness-resolve.mjs --test test/store.test.js
# tests 39  # pass 38  # fail 1
$ node scripts/ds-bot-patches.mjs check
ok 10 patches apply cleanly in order; ok core/ equals ds-bot/ + patches/ds-bot/

Review points, at bfee86c2b7c036d19325ba51177c667941b1e076:

• core/src/host/store.js:250-254: the new parsed?.version === undefined branch sits after the version === 1 branch (:224) and the version === STATE_VERSION branch (:240), and the diff is +6 lines with no other change, so the v1 migration and the current-version accept path are untouched. parsed?.version === undefined catches {}, null, [] and ""; {"version":999} still reaches store.js:256, and core/test/store.test.js:208 still asserts saved by a newer FlyBot; update FlyBot and passes.
• Red first: with core/src/host/store.js swapped back to the base blob from 214b2273 and the new tests kept, store.test.js goes 38 pass / 1 fail. Failure line: not ok 38 - a team file with no version is reported as incomplete, not as a newer FlyBot; actual: 'The Bot team file /tmp/ds-bot-store-taq2uB/state.json could not be read (saved by a newer FlyBot; update FlyBot). FlyBot does not change it; fix or move the file and reload.' The source was restored byte for byte afterwards.
• Coverage: core/test/store.test.js:677 loops {}, null, [], "", asserting the incomplete sentence, no newer FlyBot, a byte-identical file after the attempted save, and no .broken- copy. :696 covers zero-byte and truncated input.
• Zero-byte note: the issue's last line asks for a 0-byte file to get the incomplete sentence, and this PR deliberately does not do that. A 0-byte file never parses, so it fails JSON.parse before the version branches and keeps the Host files take the ambient umask: team state, Bot memory, chat index and OCR cache are world-readable, and a rewrite widens a 0600 #2697/core: one room record without members makes load() reject for the life of the process #2714 path — copied to state.json.broken-<stamp>, then loaded fresh and writable (audit48/out/1-store-shapes.txt "### 4 zero bytes": readOnly: null, backup listed). It never showed the wrong sentence, and routing it to the new read-only branch would remove that recovery. docs/subsystems/core-host.md:237 and the changelog both state this. Reviewer judges that correct; the literal 0-byte acceptance line is not met and should not be.
• Scope: 214b2273...bfee86c2 is one commit, 6 files, exactly the PR's list; ds-bot-patches check reproduces core/ from patches/ds-bot/. Tip checks are all green except enqueue-guard, whose only refusal is no Verifier report names the tip bfee86c2b7c0 — this PASS is that report. agent-pr is set and the checkpoint block is valid (6 files, checks.at a 40-character sha, 1181 characters).

Not run: full npm run verify / generate / canonical (this host has no git); the affected store.test.js and install.test.js, the source-only red run, and the patch check above cover the change.